Apply JSS and SXA Web.config transforms #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Lui <[email protected]> (+9 squashed commit) Squashed commit: [e74d0cf] JSS v15 variation for Sitecore 10 containers (Sitecore#403) s [f2c341d] Switching namespaces to match internal names (Sitecore#406) [1880301] Updated Change log Signed-off-by: Vincent Lui <[email protected]> [e43d1f3] Fixing the build stages target for XP / XP0 SXA / JSS Signed-off-by: Vincent Lui <[email protected]> [b62a3e7] Fixing the build stages target for XM SXA / JSS Signed-off-by: Vincent Lui <[email protected]> [9c27dac] Resetting the Dockerfile in sitecore-custom-base Signed-off-by: Vincent Lui <[email protected]> [f1e463d] Added a step to run web.config transform after each module is installed Signed-off-by: Vincent Lui <[email protected]> [bf78cd1] Added a step to run web.config transform after each module is installed Signed-off-by: Vincent Lui <[email protected]> [79f06d4] Added a step to run web.config transform after each module is installed Signed-off-by: Vincent Lui <[email protected]> Added a step to run web.config transform after each module is installed Signed-off-by: Vincent Lui <[email protected]> Added a step to run web.config transform after each module is installed Signed-off-by: Vincent Lui <[email protected]> Added a step to run web.config transform after each module is installed Signed-off-by: Vincent Lui <[email protected]> Resetting the Dockerfile in sitecore-custom-base Signed-off-by: Vincent Lui <[email protected]> Fixing the build stages target for XM SXA / JSS Signed-off-by: Vincent Lui <[email protected]> Fixing the build stages target for XP / XP0 SXA / JSS Signed-off-by: Vincent Lui <[email protected]> Updated Change log Signed-off-by: Vincent Lui <[email protected]> Fixing DockerFile target for JSS containers after rebase Signed-off-by: Vincent Lui <[email protected]>
vtml
requested review from
bplasmeijer and
jeanfrancoislarente
as code owners
vtml
changed the title
vtml
changed the title
|
Going to use PR #416 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Image Details
Pull Request Details
The web.config transforms were not run for Sitecore 10 JSS CM / CD, and Sitecore 10 SXA CD role.
Which issue(s) this PR fixes:
Fixes #
#387
Special notes for your reviewer:
Pre-submit Checklist
I have read and am familiar with the contents of CONTRIBUTING.md
I have built the images locally (all relevant OS versions, including Linux if applicable)
.\build.ps1command used (don't forget to exclude your credentials!)docker system prune -af)build/windows/testsfolderbuild\update-documentation.ps1build\CHANGELOG.mdwith details about the change(s) included