Skip to content

Commit

Permalink
#544756: [templates/nextjs-sxa] added cdn for font-awesome font (#1536)
Browse files Browse the repository at this point in the history
* #544756: added cdn for font-awesome font

There was problem with CORS and getting fonts

*  #544756: changed CHANGELOG
  • Loading branch information
sc-ruslanmatkovskyi authored Jun 27, 2023
1 parent fd88a96 commit 270a5dc
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Our versioning strategy is as follows:

### 🐛 Bug Fixes

* `[templates/nextjs-sxa]` Fix font awesome - added CDN instead of using node_modules(problem with CORS) ([#1536](https://github.com/Sitecore/jss/pull/1536))
* `[templates/nextjs-sxa]` Fix menu component of third-level menu. ([#1540](https://github.com/Sitecore/jss/pull/1540))
* `[sitecore-jss-react]` [FEaaS] Prevent extra components client-side requests for SSR ([1541](https://github.com/Sitecore/jss/pull/1541))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"dependencies": {
"@sitecore-feaas/clientside": "^0.3.0",
"bootstrap": "^5.1.3",
"font-awesome": "^4.7.0",
"sass": "^1.52.3",
"sass-alias": "^1.0.5"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
@import url('https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500;700&display=swap');
/* FontAwesome */
@import url('https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css');
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@import "basic/fonts";
@import "font-awesome/scss/font-awesome";
@import "bootstrap/scss/bootstrap";
@import "sass/main.scss";
@import "basic/main.scss";

0 comments on commit 270a5dc

Please sign in to comment.