[CLI] Handle underscores in app name when replacing prefix (#817)

* Handle underscores in app name when replacing prefix * Remove display name from vue content block
Sitecore · Sep 20, 2021 · 3fc85de · 3fc85de
1 parent f9e0450
commit 3fc85de
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/sitecore-jss-cli/src/create/index.test.ts b/packages/sitecore-jss-cli/src/create/index.test.ts
@@ -216,6 +216,12 @@ describe('getPascalCaseName', () => {
     expect(result).to.match(/MyNextSitecoreApp/);
   });
 
+  it('should reformat snake_case to PascalCase', () => {
+    const result = getPascalCaseName('my_next_sitecore_app');
+
+    expect(result).to.match(/MyNextSitecoreApp/);
+  });
+
   it('should reformat one word lowercase app name to be capitalized', () => {
     const result = getPascalCaseName('onewordappnamenohyphen');
 

diff --git a/packages/sitecore-jss-cli/src/create/index.ts b/packages/sitecore-jss-cli/src/create/index.ts
@@ -117,7 +117,8 @@ export function applyNameToProject(
  * @param {string} name
  */
 export function getPascalCaseName(name: string): string {
-  const temp: string[] = name.split('-');
+  // handle underscores by converting them to hyphens
+  const temp: string[] = name.replace(/_/g, '-').split('-');
   name = temp.map((item: string) => (item = item.charAt(0).toUpperCase() + item.slice(1))).join('');
   return name;
 }

diff --git a/samples/vue/sitecore/definitions/components/ContentBlock.sitecore.js b/samples/vue/sitecore/definitions/components/ContentBlock.sitecore.js
@@ -10,7 +10,6 @@ export default function(manifest) {
   manifest.addComponent({
     name: 'ContentBlock',
     templateName: 'JssVueWeb-ContentBlock',
-    displayName: 'Content Block',
     // totally optional, but fun
     icon: SitecoreIcon.DocumentTag,
     fields: [