[nextjs-sxa] hotfix eslint for building nextjs-sxa (#1046)

* hotfix eslint for building nextjs-sxa * hotfix eslint for building nextjs-sxa * #hotfix fixed lint errors
Sitecore · May 31, 2022 · 962bf7a · 962bf7a
1 parent eb2c990
commit 962bf7a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 15 deletions.
diff --git a/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/Container.tsx b/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/Container.tsx
@@ -20,7 +20,7 @@ const Container = (props: ComponentProps): JSX.Element => {
   const styles = `${props.params.GridParameters} ${props.params.Styles}`.trimEnd();
   const phKey = `container-${props.params.DynamicPlaceholderId}`;
   const backgroundImage = props.params.BackgroundImage as string;
-  let backgroundStyle: { [key: string]: string };
+  let backgroundStyle: { [key: string]: string } = { backgroundImage: ''};
 
   if (backgroundImage) {
     const prefix = `${sitecoreContext.pageState !== 'normal' ? '/sitecore/shell' : ''}/-/media/`;

diff --git a/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/PageContent.tsx b/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/components/PageContent.tsx
@@ -39,10 +39,12 @@ export const Default = (props: PageContentProps): JSX.Element => {
     );
   }
 
-  const field =
+  const field = (
     props.fields && props.fields.Content
       ? props.fields.Content
-      : sitecoreContext?.route?.fields?.Content;
+      : sitecoreContext?.route?.fields?.Content
+  ) as RichTextField;
+
   return (
     <ComponentContent styles={props.params.styles}>
       <JssRichText field={field} />

diff --git a/...-sitecore-jss/src/templates/nextjs-sxa/src/components/PartialDesignDynamicPlaceholder.tsx b/...-sitecore-jss/src/templates/nextjs-sxa/src/components/PartialDesignDynamicPlaceholder.tsx
@@ -1,13 +1,12 @@
 import React from 'react';
-import { Placeholder } from '@sitecore-jss/sitecore-jss-nextjs';
-import { ComponentRendering, RouteData } from '@sitecore-jss/sitecore-jss/layout';
+import { Placeholder, ComponentRendering } from '@sitecore-jss/sitecore-jss-nextjs';
 
 type DynamicPlaceholderProps = {
-  rendering: ComponentRendering | RouteData;
+  rendering: ComponentRendering;
 };
 
 const PartialDesignDynamicPlaceholder = (props: DynamicPlaceholderProps): JSX.Element => (
-  <Placeholder name={props.rendering.params.sig} rendering={props.rendering} />
+  <Placeholder name={props.rendering?.params?.sig || ''} rendering={props.rendering} />
 );
 
 export default PartialDesignDynamicPlaceholder;
diff --git a/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts b/packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts
@@ -6,7 +6,9 @@ import { AxiosDataFetcher, GraphQLSitemapXmlService } from '@sitecore-jss/siteco
 const ABSOLUTE_URL_REGEXP = '^(?:[a-z]+:)?//';
 
 const sitemapApi = async (req: NextApiRequest, res: NextApiResponse): Promise<NextApiResponse | void> => {
-  const { query: { id } } = req;
+  const {
+    query: { id },
+  } = req;
   // create sitemap graphql service
   const sitemapXmlService = new GraphQLSitemapXmlService({
     endpoint: config.graphQLEndpoint,
@@ -21,13 +23,14 @@ const sitemapApi = async (req: NextApiRequest, res: NextApiResponse): Promise<Ne
     const sitemapUrl = isAbsoluteUrl ? sitemapPath : `${config.sitecoreApiHost}${sitemapPath}`;
     res.setHeader('Content-Type', 'text/xml;charset=utf-8');
 
-    return new AxiosDataFetcher().get(sitemapUrl, {
-      responseType: 'stream',
-    })
-    .then((response: AxiosResponse) => {
-      response.data.pipe(res);
-    })
-    .catch(() => res.redirect('/404'));
+    return new AxiosDataFetcher()
+      .get(sitemapUrl, {
+        responseType: 'stream',
+      })
+      .then((response: AxiosResponse) => {
+        response.data.pipe(res);
+      })
+      .catch(() => res.redirect('/404'));
   }
 
   res.redirect('/404');