[sitecore-jss-nextjs] Reduce the amount of Edge API calls during fetc…

…h `getStaticPaths` (#1612) * change sitemap service pageSize, serialize getStaticPaths * update changelog
Sitecore · Sep 15, 2023 · fb32a11 · fb32a11
1 parent d1f7455
commit fb32a11
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -32,6 +32,7 @@ Our versioning strategy is as follows:
 * `[sitecore-jss-react]` Fetch Data for FEaaS Components as part of Component SSR/SSG ([#1586](https://github.com/Sitecore/jss/pull/1590))
 * `[sitecore-jss-dev-tools]` `[templates/nextjs]` `[templates/react]` Introduce "components" configuration for ComponentBuilder ([#1598](https://github.com/Sitecore/jss/pull/1598))
 * `[sitecore-jss-react]` `[sitecore-jss-nextjs]` Component level data fetching(SSR/SSG) for BYOC ([#1610](https://github.com/Sitecore/jss/pull/1610))
+* `[sitecore-jss-nextjs]` Reduce the amount of Edge API calls during fetch getStaticPaths ([#1612](https://github.com/Sitecore/jss/pull/1612))
 
 ### 🧹 Chores
 

diff --git a/packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts b/packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts
@@ -27,7 +27,7 @@ query ${usesPersonalize ? 'PersonalizeSitemapQuery' : 'DefaultSitemapQuery'}(
   $language: String!
   $includedPaths: [String]
   $excludedPaths: [String]
-  $pageSize: Int = 10
+  $pageSize: Int = 100
   $after: String
 ) {
   site {
@@ -86,7 +86,7 @@ interface SiteRouteQueryVariables {
   /** common variable for all GraphQL queries
    * it will be used for every type of query to regulate result batch size
    * Optional. How many result items to fetch in each GraphQL call. This is needed for pagination.
-   * @default 10
+   * @default 100
    */
   pageSize?: number;
 }
@@ -223,21 +223,24 @@ export abstract class BaseGraphQLSitemapService {
     formatStaticPath: (path: string[], language: string) => StaticPath
   ) {
     const paths = new Array<StaticPath>();
-    await Promise.all(
-      languages.map(async (language) => {
-        if (language === '') {
-          throw new RangeError(languageEmptyError);
-        }
-        debug.sitemap('fetching sitemap data for %s %s', language, siteName);
-        const results = await this.fetchLanguageSitePaths(language, siteName);
-        const transformedPaths = await this.transformLanguageSitePaths(
-          results,
-          formatStaticPath,
-          language
-        );
-        paths.push(...transformedPaths);
-      })
-    );
+
+    for (const language of languages) {
+      if (language === '') {
+        throw new RangeError(languageEmptyError);
+      }
+
+      debug.sitemap('fetching sitemap data for %s %s', language, siteName);
+
+      const results = await this.fetchLanguageSitePaths(language, siteName);
+      const transformedPaths = await this.transformLanguageSitePaths(
+        results,
+        formatStaticPath,
+        language
+      );
+
+      paths.push(...transformedPaths);
+    }
+
     return paths;
   }
 

diff --git a/packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts b/packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts
@@ -439,7 +439,8 @@ describe('GraphQLSitemapService', () => {
           .post(
             '/',
             (body) =>
-              body.query.indexOf('$pageSize: Int = 10') > 0 && body.variables.pageSize === undefined
+              body.query.indexOf('$pageSize: Int = 100') > 0 &&
+              body.variables.pageSize === undefined
           )
           .reply(200, sitemapDefaultQueryResult);