Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates] Add script to restore yarn.lock #1004

Merged
merged 7 commits into from
May 6, 2022

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented May 4, 2022

When following our new workflow (npm run watch) the root yarn.lock file will result in dependencies being added for the initialized app (since we are using yarn workspace). This is a problem because developers must be aware of these changes and not commit them to source control. This script will restore the yarn.lock file after app initialization is complete.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team May 4, 2022 17:46
packages/create-sitecore-jss/scripts/watch-templates.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/scripts/watch-templates.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/package.json Outdated Show resolved Hide resolved
packages/create-sitecore-jss/scripts/post-install.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple naming suggestions

packages/create-sitecore-jss/watch.json.example Outdated Show resolved Hide resolved
packages/create-sitecore-jss/scripts/watch-templates.ts Outdated Show resolved Hide resolved
@addy-pathania addy-pathania merged commit a4a583c into dev May 6, 2022
@addy-pathania addy-pathania deleted the feature/514076-restore-yarn-lock branch May 6, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants