Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/graphql nextjs sitemap update #1007

Merged
merged 10 commits into from
May 6, 2022
Merged

Feature/graphql nextjs sitemap update #1007

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dcf79b3
Changing sitemap GraphQL query from 'search' to 'site' plus adding a …
art-alexeyenko Apr 28, 2022
9123e38
Addressing existing tests
art-alexeyenko Apr 28, 2022
01a752c
Cleanup, comments and adding tests
art-alexeyenko Apr 28, 2022
099a930
Test and comment cleanup
art-alexeyenko Apr 29, 2022
84ff917
Addressing Adam's comments - moving site query logic into nextjs project
art-alexeyenko May 3, 2022
ef20465
remove extra files
art-alexeyenko May 3, 2022
cdcb62b
more cleanup
art-alexeyenko May 3, 2022
9bb7d39
Fixed variables in GQL query
art-alexeyenko May 5, 2022
7b2001f
small query change
art-alexeyenko May 5, 2022
c910b94
Merge branch 'dev' of https://github.com/art-alexeyenko/jss into feat…
art-alexeyenko May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...ecore-jss/src/templates/nextjs/src/lib/sitemap-fetcher/plugins/graphql-sitemap-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ class GraphqlSitemapServicePlugin implements SitemapFetcherPlugin {
endpoint: config.graphQLEndpoint,
apiKey: config.sitecoreApiKey,
siteName: config.jssAppName,
/*
The Sitemap Service needs a root item ID in order to fetch the list of pages for the current
app. If your Sitecore instance only has 1 JSS App, you can specify the root item ID here;
otherwise, the service will attempt to figure out the root item for the current JSS App using GraphQL and app name.
rootItemId: '{GUID}'
*/
});
}

Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss-nextjs/src/edge/redirects-middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class RedirectsMiddleware {
/**
* Method returns RedirectInfo when matches
* @param url
* @return Promise<RedirectInfo>
* @returns Promise<RedirectInfo>
* @private
*/
private async getExistsRedirect(url: URL): Promise<RedirectInfo | undefined> {
Expand Down
Loading