Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-headless-ssr-proxy][node-headless-ssr-experience-edge] Fix invalid default bundle path #1027

Merged
merged 5 commits into from
May 18, 2022
Merged

[node-headless-ssr-proxy][node-headless-ssr-experience-edge] Fix invalid default bundle path #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9877a59
Converted node-headless-ssr-experience-edge and node-headless-ssr-pro…
sc-nikolaoslazaridis May 9, 2022
a229308
Requested changes
sc-nikolaoslazaridis May 10, 2022
4a149c8
Added apiKey to ServerBundle interface
sc-nikolaoslazaridis May 10, 2022
941d108
Changed bundlePath default value to the correct one
sc-nikolaoslazaridis May 18, 2022
59841c9
Merge branch 'dev' into feature/528800-Add-typescript-to-the-sample
sc-nikolaoslazaridis May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ const appName = process.env.SITECORE_JSS_APP_NAME;
/**
* The server.bundle.js file from your pre-built JSS app
*/
const bundlePath = process.env.SITECORE_JSS_SERVER_BUNDLE || `./dist/${appName}/server.bundle`;

const bundlePath = process.env.SITECORE_JSS_SERVER_BUNDLE || `../dist/${appName}/server.bundle`;

const serverBundle: ServerBundle = require(bundlePath);

Expand Down
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ let appName = process.env.SITECORE_JSS_APP_NAME || 'YOUR APP NAME';
/**
* The server.bundle.js file from your pre-built JSS app
*/
const bundlePath = process.env.SITECORE_JSS_SERVER_BUNDLE || `./dist/${appName}/server.bundle`;

const bundlePath = process.env.SITECORE_JSS_SERVER_BUNDLE || `../dist/${appName}/server.bundle`;

const serverBundle = require(bundlePath) as ServerBundle;

Expand Down