Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NextJs] Specify AppProps generic type in _app.tsx to align with latest changes from Next 12.3.0 #1154

Merged
merged 3 commits into from
Sep 15, 2022
Merged

[NextJs] Specify AppProps generic type in _app.tsx to align with latest changes from Next 12.3.0 #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
016da32
[NextJs] Specify AppProps generic type in _app.tsx to align with late…
illiakovalenko Sep 13, 2022
226d685
Use SitecorePageProps
illiakovalenko Sep 15, 2022
90d7c8e
revert
illiakovalenko Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/nextjs-styleguide/src/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { AppProps } from 'next/app';
import Router from 'next/router';
import { I18nProvider } from 'next-localization';
import NProgress from 'nprogress';
import { SitecorePageProps } from 'lib/page-props';

// Using bootstrap and nprogress are completely optional.
// bootstrap is used here to provide a clean layout for samples, without needing extra CSS in the sample app
Expand All @@ -17,7 +18,7 @@ Router.events.on('routeChangeStart', () => NProgress.start());
Router.events.on('routeChangeComplete', () => NProgress.done());
Router.events.on('routeChangeError', () => NProgress.done());

function App({ Component, pageProps }: AppProps): JSX.Element {
function App({ Component, pageProps }: AppProps<SitecorePageProps>): JSX.Element {
const { dictionary, ...rest } = pageProps;

return (
Expand Down
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type { AppProps } from 'next/app';
import { I18nProvider } from 'next-localization';
import { SitecorePageProps } from 'lib/page-props';

import 'assets/main.scss';

function App({ Component, pageProps }: AppProps): JSX.Element {
function App({ Component, pageProps }: AppProps<SitecorePageProps>): JSX.Element {
const { dictionary, ...rest } = pageProps;

return (
Expand Down
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/nextjs/src/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type { AppProps } from 'next/app';
import { I18nProvider } from 'next-localization';
import { SitecorePageProps } from 'lib/page-props';

import 'assets/app.css';

function App({ Component, pageProps }: AppProps): JSX.Element {
function App({ Component, pageProps }: AppProps<SitecorePageProps>): JSX.Element {
const { dictionary, ...rest } = pageProps;

return (
Expand Down