Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sitecore-jss extra unit test coverage #1262

Merged
merged 2 commits into from
Dec 16, 2022
Merged

sitecore-jss extra unit test coverage #1262

merged 2 commits into from
Dec 16, 2022

Conversation

art-alexeyenko
Copy link
Contributor

Small increase for base package unit test coverage

  • Ignore files that don't have executable logic
  • Add tests where it makes sense

@art-alexeyenko art-alexeyenko requested a review from a team December 16, 2022 16:28
@art-alexeyenko art-alexeyenko changed the title sitecore-jss: first batch of tests sitecore-jss extra unit test coverage Dec 16, 2022
ambrauer
ambrauer approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ambrauer ambrauer merged commit 8b55663 into dev Dec 16, 2022
@ambrauer ambrauer deleted the feature/jss-package-unit-test-coverage branch December 16, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @ambrauer