Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitecore-jss-cli package unit test coverage #1263

Merged
merged 9 commits into from
Dec 20, 2022

Conversation

art-alexeyenko
Copy link
Contributor

Increase unit test coverage for jss-cli package.

  • Filter out files that should not be tested;
  • Add test cases when it makes sense.

@art-alexeyenko art-alexeyenko requested a review from a team December 16, 2022 21:31
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just one question. Also, looks like you may need to regenerate the yarn.lock file.

packages/sitecore-jss-cli/.nycrc Outdated Show resolved Hide resolved
packages/sitecore-jss-cli/src/cli.test.ts Show resolved Hide resolved
packages/sitecore-jss-cli/src/cli.test.ts Show resolved Hide resolved
@art-alexeyenko art-alexeyenko merged commit 6a1c277 into dev Dec 20, 2022
@art-alexeyenko art-alexeyenko deleted the feature/jss-cli-package-unit-test-coverage branch December 20, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants