Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Upgrade 3rd party dependencies #1301

Merged
merged 5 commits into from
Jan 24, 2023
Merged

[Vue] Upgrade 3rd party dependencies #1301

merged 5 commits into from
Jan 24, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jan 24, 2023 •
edited
Loading

  • Upgraded vue template/package 3rd party dependencies.
  • Added jest-environment-jsdom so the user can use browser like test environment.
  • Upgraded jest modules and added @vue/vue3-jest to make it compatible with the latest vue version.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team January 24, 2023 14:41
ambrauer
ambrauer approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please resolve conflicts and can merge once checks pass.

@ambrauer ambrauer merged commit 4a77438 into dev Jan 24, 2023
@ambrauer ambrauer deleted the feature/513287-vue-upgrade branch January 24, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @ambrauer