Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Apply missing bootstrap styles after upgrade #1341

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[React] Apply missing bootstrap styles after upgrade #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/react/data/routes/styleguide/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ placeholders:
href: https://dev.sitecore.net
text: Sitecore Dev Site
target: _blank
class: font-weight-bold
class: fw-bold
title: <a> title attribute
- componentName: Styleguide-FieldUsage-ItemLink
fields:
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/react/src/Layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import logo from './assets/sc_logo.svg';
// Most apps may also wish to use GraphQL for their navigation construction; this sample does not simply to support disconnected mode.
let Navigation = ({ t, i18n }) => (
<div className="d-flex flex-column flex-md-row align-items-center p-3 px-md-4 mb-3 bg-white border-bottom">
<h5 className="my-0 me-md-auto font-weight-normal">
<h5 className="my-0 me-md-auto fw-normal">
<NavLink to="/" className="text-dark">
<img src={logo} alt="Sitecore" />
</NavLink>
Expand Down
2 changes: 1 addition & 1 deletion ...reate-sitecore-jss/src/templates/react/src/components/Styleguide-FieldUsage-Link/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const StyleguideFieldUsageLink = (props) => (
<Link
field={props.fields.externalLink}
showLinkTextWithChildrenPresent={true}
className="font-weight-bold"
className="fw-bold"
data-otherattributes="pass-through-to-anchor-tag"
/>
</StyleguideSpecimen>
Expand Down
2 changes: 1 addition & 1 deletion ...reate-sitecore-jss/src/templates/react/src/components/Styleguide-FieldUsage-Text/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const StyleguideFieldUsageText = (props) => (
tag="section"
editable={false}
encode={false}
className="font-weight-bold"
className="fw-bold"
data-sample="other-attributes-pass-through"
/>

Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/react/src/components/Styleguide-Layout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const StyleguideLayout = (props) => {
}))
.map((section) => (
<nav key={section.heading} className="nav flex-column pt-2">
<a href={`#${section.id}`} className="nav-item font-weight-bold">
<a href={`#${section.id}`} className="nav-item fw-bold">
{section.heading}
</a>
{section.children && (
Expand Down