Edit frame component implementation #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
requested changes
Feb 17, 2023
...emplates/angular/src/app/components/styleguide-edit-frame/styleguide-edit-frame.component.ts
Outdated
Show resolved
Hide resolved
...emplates/angular/src/app/components/styleguide-edit-frame/styleguide-edit-frame.component.ts
Show resolved
Hide resolved
...emplates/angular/src/app/components/styleguide-edit-frame/styleguide-edit-frame.component.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/react/src/components/Styleguide-EditFrame/index.js
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/editframe.component.spec.ts
Show resolved
Hide resolved
packages/sitecore-jss-angular/src/components/editframe.component.ts
Outdated
Show resolved
Hide resolved
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HUGE thanks to @mjarosch for the initial PR (#1253) and doing the discovery, investigation and the component implementation.
This adds an Edit Frame component, similar to the one that was available for Sitecore's MVC site implementations.
The PR includes:
Testing Details
Manual testing + new unit tests for each framework.
Types of changes