Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-proxy] The rewriteRequestPath function ignores query string parameters added in a middleware #1373

Merged
merged 4 commits into from
Mar 14, 2023
Merged

[sitecore-jss-proxy] The rewriteRequestPath function ignores query string parameters added in a middleware #1373

merged 4 commits into from
Mar 14, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Mar 10, 2023 •
edited
Loading

Description / Motivation

When url didn't include query string parameters, in this case query string parameters provided by middleware (req.query) were skipped

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team March 10, 2023 13:48
art-alexeyenko
art-alexeyenko reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reqPath in here can miss some qs params, should this method call be performed with modified reqPath (to ensure we test exclude logic against a full path with full query string)?

art-alexeyenko
art-alexeyenko approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to go.
I just left one comment on a potential edge case.

packages/sitecore-jss-proxy/src/index.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit a449fe8 into dev Mar 14, 2023
@illiakovalenko illiakovalenko deleted the bugfix/570511 branch March 14, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @art-alexeyenko