[Vue] Disconnected mode doesn't start in monorepo #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
In case requireArg is not provided, the disconnected server manifest generation is started using sitecore/definitions/config.js transpiler, that is working fine for us (and uses same the @babel/register package).
As a worst case it would be possible to work around that by using
path.resolve(process.cwd(), 'node_modules/@babel/register'). Since in monorepo some packages can be placed in the root node_modules it's required to provide exact path if module imported from a different package, like hereTesting Details
Types of changes