Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Fix Compilation Error #1428

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Apr 11, 2023

eslint-config-react-app in react-scripts already have the dependency eslint-plugin-react therefore because of the duplicate dependency and mismatch in the version causes this compilation error.
The workaround to resolve this error is to remove the yarn.lock and regenerate again.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team April 11, 2023 17:13
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
You can also specify the error occurs in monorepo setup in the Changelog entry.

CHANGELOG.md Outdated Show resolved Hide resolved
addy-pathania and others added 2 commits April 12, 2023 12:53
Co-authored-by: Adam Brauer <[email protected]>
Co-authored-by: Adam Brauer <[email protected]>
@addy-pathania addy-pathania requested a review from ambrauer April 12, 2023 17:07
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last missed rename, otherwise looks good to me 👍

@addy-pathania addy-pathania merged commit 8b732ce into dev Apr 13, 2023
@addy-pathania addy-pathania deleted the fix/566499-react-compile-error branch April 13, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants