Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEaaS][nextjs-sxa] Fetch revision based on page state #1433

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Apr 14, 2023

Description / Motivation

FEaaS Components follow a lifecycle different from Sitecore items so Layout Service will not always provide JSS apps with the correct component revision to show.
This PR puts revision resolution into JSS logic:

  • In editing and preview modes, 'staged' FEaaS variants should be rendered by default;
  • Variant can be overridden via ComponentRevision rendering parameter field from a FEaaS rendering.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - connected mode tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team April 14, 2023 16:20
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@illiakovalenko illiakovalenko merged commit 4226a64 into dev Apr 18, 2023
@illiakovalenko illiakovalenko deleted the feature/578694-feaas-stage-prod-variants branch April 18, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants