Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-push-hook] Fix error when initializing angular app #1444

Merged
merged 8 commits into from
Apr 24, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Apr 21, 2023

The process does not exit if there is a error during installation of pre-push hook and it continues to install the app successfully.
This fix exits the process as soon as it encounters the error.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from ambrauer April 21, 2023 23:58
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one suggestion and please update CHANGELOG. Otherwise, looks good to me.

addy-pathania and others added 2 commits April 24, 2023 09:32
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit 4e188b5 into dev Apr 24, 2023
@ambrauer ambrauer deleted the fix/582530-angular-error branch April 24, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants