Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node-headless-ssr-experience-edge] Add helper comment for rootItemId #1491

Merged
merged 2 commits into from
May 19, 2023
Merged

[node-headless-ssr-experience-edge] Add helper comment for rootItemId #1491

merged 2 commits into from
May 19, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented May 19, 2023 •
edited
Loading

The node-headless-ssr-experience-edge template doesn't have the helper comment to add the rootItemId if missing.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team May 19, 2023 00:09
art-alexeyenko
art-alexeyenko approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@addy-pathania addy-pathania merged commit 6e3992c into dev May 19, 2023
@addy-pathania addy-pathania deleted the bug/584709-root-item-id branch May 19, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @art-alexeyenko