Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/vue] "lint" command is failing due to bug introduced by eslint-plugin-prettier #1563

Merged
merged 2 commits into from
Jul 18, 2023
Merged

[templates/vue] "lint" command is failing due to bug introduced by eslint-plugin-prettier #1563

merged 2 commits into from
Jul 18, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jul 18, 2023 •
edited
Loading

Description / Motivation

  • Upgraded eslint-plugin-prettier to the latest version
  • Installed prettier since it's a peer dependency

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team July 18, 2023 11:54
@illiakovalenko illiakovalenko changed the title [samples/vue] "lint" command is failing due to bug introduced by eslint-plugin-prettier [templates/vue] "lint" command is failing due to bug introduced by eslint-plugin-prettier Jul 18, 2023
addy-pathania
addy-pathania approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@addy-pathania addy-pathania merged commit 240fbaa into dev Jul 18, 2023
@addy-pathania addy-pathania deleted the bugfix/591128 branch July 18, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @addy-pathania