Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates] Add JSS_APP_NAME to .env files #1571

Merged
merged 3 commits into from
Jul 24, 2023
Merged

[templates] Add JSS_APP_NAME to .env files #1571

merged 3 commits into from
Jul 24, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jul 24, 2023 •
edited
Loading

Description / Motivation

Introduced a new JSS_APP_NAME environment variable allowing to override package.json config.appName property

Testing Details

  • Unit Test Added
  • Manual Test/Other - Tested all the base templates using connected mode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team July 24, 2023 10:20
@illiakovalenko illiakovalenko requested a review from ambrauer July 24, 2023 13:05
@illiakovalenko illiakovalenko merged commit 1d31c5d into dev Jul 24, 2023
@illiakovalenko illiakovalenko deleted the feature/JSS-214 branch July 24, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer