Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-react] Fetch Data for FEaaS Components as part of Component SSR/SSG #1590

Merged
merged 10 commits into from
Aug 18, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Aug 15, 2023

Components that placed on the Page can be configured to fetch their own data at runtime.
Currently JSS only fetches HTML on the server, this feature adds server side rendering where HTML and JS both may be fetched and rendered as static html.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team August 15, 2023 23:23
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@illiakovalenko illiakovalenko merged commit a981585 into dev Aug 18, 2023
@illiakovalenko illiakovalenko deleted the feature/jss-70-fetch-data-feaas branch August 18, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants