Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] [sitecore-jss-react] Component level data fetching(SSR/SSG) for BYOC #1610

Merged
merged 10 commits into from
Sep 13, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Sep 11, 2023

Components that placed on the Page can be configured to fetch their own data at runtime.
Currently JSS only fetches HTML on the server, this feature adds server side rendering where HTML and JS both may be fetched and rendered as static html.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team September 12, 2023 04:27
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See some comments below

Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, see a few notes below
And, can you, please update a description of the PR?

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Illia Kovalenko <[email protected]>
@addy-pathania addy-pathania changed the title [sitecore-jss-nextjs] [sitecore-jss-react] Component level data fetching(SSR) for BYOC [sitecore-jss-nextjs] [sitecore-jss-react] Component level data fetching(SSR/SSG) for BYOC Sep 12, 2023
@addy-pathania addy-pathania merged commit 2ac8c8c into dev Sep 13, 2023
@addy-pathania addy-pathania deleted the feature/jss-491-fetch-data-byoc branch September 13, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants