-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sitecore-jss-nextjs] [sitecore-jss-react] Component level data fetching(SSR/SSG) for BYOC #1610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! See some comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, see a few notes below
And, can you, please update a description of the PR?
Co-authored-by: Illia Kovalenko <[email protected]>
…/jss into feature/jss-491-fetch-data-byoc
Components that placed on the Page can be configured to fetch their own data at runtime.
Currently JSS only fetches HTML on the server, this feature adds server side rendering where HTML and JS both may be fetched and rendered as static html.
Description / Motivation
Testing Details
Types of changes