Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#603676: [sitecore-jss-nextjs] fixed redirect middleware logic #1676

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Nov 24, 2023

Description / Motivation

When param of trailingSlash is true the targetURL in redirects middleware logic doesn't match with pattern.
Added a little fix in logic.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Ruslan Matkovskyi added 3 commits November 24, 2023 01:23
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@addy-pathania addy-pathania merged commit be6bf8b into dev Nov 27, 2023
1 check passed
@addy-pathania addy-pathania deleted the bugfix/603676-redirects-middleware-trailing-slash branch November 27, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants