Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Replaced deprecated "npm bin" by "npm exec" #1681

Merged
merged 3 commits into from
Dec 4, 2023
Merged

[Chore] Replaced deprecated "npm bin" by "npm exec" #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d89818f
Updated npm script to use "npm exec" instead of "npm bin"
illiakovalenko Dec 4, 2023
a05e20d
Updated CHANGELOG
illiakovalenko Dec 4, 2023
3510060
CHANGELOG
illiakovalenko Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Our versioning strategy is as follows:

### 🧹 Chores

* Upgrade to Node.js 20.x ([#1679](https://github.com/Sitecore/jss/pull/1679))
* Upgrade to Node.js 20.x ([#1679](https://github.com/Sitecore/jss/pull/1679))([#1681](https://github.com/Sitecore/jss/pull/1681))

### 🐛 Bug Fixes

Expand Down
4 changes: 2 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ steps:
# * Only run for 'dev' and 'release' branches
#
- script: |
$(npm bin)/lerna version prerelease --exact --preid canary --force-publish --message "version %s [skip ci]" --yes
npm exec -- lerna version prerelease --exact --preid canary --force-publish --message "version %s [skip ci]" --yes
displayName: 'pre-release version update'
condition: and(succeeded(), eq(variables.shouldPublish, true))
env:
Expand All @@ -133,7 +133,7 @@ steps:
#
- script: |
echo //registry.npmjs.org/:_authToken=${NPM_TOKEN} > .npmrc
$(npm bin)/lerna publish from-git --canary --pre-dist-tag canary --preid canary --no-verify-access --yes
npm exec -- lerna publish from-git --canary --pre-dist-tag canary --preid canary --no-verify-access --yes
yarn install --no-immutable --mode=update-lockfile
git add yarn.lock
git commit -m "update yarn.lock [skip ci]"
Expand Down