Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double registration of byoc components #1707

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix double registration of byoc components #1707

merged 2 commits into from
Jan 4, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jan 4, 2024 •
edited
Loading

BYOC components doesn't render on pages because of double registration i.e one on server and another on client.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team January 4, 2024 18:10
ambrauer
ambrauer approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@addy-pathania addy-pathania merged commit 3508b8f into dev Jan 4, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-1284-byoc-double-inclusion branch January 4, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @ambrauer