Support stylesheets for BYOC Unwrapped and SXA Components #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorsk
changed the title
[templates/nextjs-xmcloud] [sitecore-jss] Support stylesheets for BYOC Unwrapped and SXA Components
yavorsk
changed the title
[templates/nextjs-xmcloud] [sitecore-jss] Support stylesheets for BYOC Unwrapped and SXA Components
yavorsk
requested review from
illiakovalenko,
art-alexeyenko and
addy-pathania
illiakovalenko
requested changes
Jan 24, 2024
illiakovalenko
approved these changes
Jan 26, 2024
Co-authored-by: Illia Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Adding support for loading appropriate stylesheets whenever a theme is applied to BYOC and SXA components (built on top of #1587 ).
This PR introduces new function getComponentLibraryStylesheetLinks, which replaces getFEAASLibraryStylesheetLinks (which is marked as deprecated) and supports FEAAS, BYOC and SXA components;
Testing Details
Types of changes