Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Enable NextImage to use built-in image optimization from vercel #1726

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Feb 6, 2024

Currently the custom loader function i.e. sitecoreLoader formats the URL to use Sitecore's image optimization. However, it is limited to image resizing and we would like to use the vercel's built-in image optimization.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team February 6, 2024 00:35
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.. just one comment and there seem to be linting errors.

packages/sitecore-jss-nextjs/src/components/NextImage.tsx Outdated Show resolved Hide resolved
@addy-pathania addy-pathania changed the title Enable NextImage to use built-in image optimization from vercel [sitecore-jss-nextjs] Enable NextImage to use built-in image optimization from vercel Feb 6, 2024
@addy-pathania addy-pathania merged commit a9a4cb3 into dev Feb 6, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-1467-nextimage-optimization branch February 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants