-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next.js] [BYOC] Component Builder integration endpoint #1729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! See some comments
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/next-config/plugins/feaas.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/next-config/plugins/feaas.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/pages/api/editing/feaas/render.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/feaas-render-middleware.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
One last thought is if we want to include this under "editing" or not. Maybe we should do "/api/feaas/render" (or "/api/feaas/preview") instead and leave "editing" dedicated to our Pages/EE editing integration?
Although you are using the "editing" debug namespace so would probably need to switch that.
I could be convinced either way :)
Description / Motivation
Added a new endpoint to enable Component Builder to work with BYOC components registered in a JSS application
The
FEAASRenderMiddleware
( /api/editing/feaas/render) willIf "src" query parameter is provided, the page will render a FEAAS component.
The page provides all the registered FEAAS components
The
FEAASRender
(/feaas/render) page is responsible forIntroduced a common
RenderMiddleware
Testing Details
Types of changes