Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] #607601: redirects middleware has been fixed #1737

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Feb 14, 2024

Description / Motivation

The redirects middleware has been fixed when pattern has locale and target is absolute url. There was bug when redirect logic paste locale in absolute url

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…hen pattern has locale and target is absolute url
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/607601-redirect-language-context branch from 845c621 to 2516d0f Compare February 14, 2024 01:35
@illiakovalenko illiakovalenko merged commit daae288 into dev Feb 14, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/607601-redirect-language-context branch February 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants