Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XMCloud] node-xmcloud-proxy add-on #1863

Merged
merged 12 commits into from
Jul 31, 2024
Merged

[XMCloud] node-xmcloud-proxy add-on #1863

merged 12 commits into from
Jul 31, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jul 29, 2024 •
edited
Loading

Description / Motivation

  • Introduced a new "node-xmcloud-proxy" add-on
  • Updated "angular-xmcloud" add-on
  • Added a new Debug "proxy" namespace to use in "node-xmcloud-proxy" app
  • Exposed extra properties in Angular "server-bundle"
  • Fixed "layout-service-factory" "dictionary-service-factory" templates
  • Introduced automatic "build" process handler to avoid manual steps when configuring "node-xmcloud-proxy" app
  • Cleaned up "upgrade guide" since this feature is a part of the next release
  • Relative proxy path is expected to be provided in scope of separate task

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the base branch from dev to feature/angular-xmc-proxy July 29, 2024 22:35
@illiakovalenko illiakovalenko changed the title Feature/jss 3527 New node-xmcloud-proxy sample Jul 29, 2024
@illiakovalenko illiakovalenko changed the title New node-xmcloud-proxy sample [XMCloud] node-xmcloud-proxy add-on Jul 29, 2024
@illiakovalenko illiakovalenko requested a review from a team July 29, 2024 23:26
ambrauer
ambrauer approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Conditionally approved assuming open items are resolved.

packages/create-sitecore-jss/src/templates/angular/package.json Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/scripts/generate-config.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/package.json Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/node-xmcloud-proxy/src/index.ts Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 6dfe1bc into feature/angular-xmc-proxy Jul 31, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-3527 branch July 31, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer