Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template/angular-sxp] Fix build error of angular-sxp, service not found #1890

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Aug 14, 2024

Description / Motivation

Fixes a build error of angular+angular-sxp app by removing the angular-xmcloud specific link service from app.module and providing it via provideIn='root'

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested review from illiakovalenko and a team August 14, 2024 08:14
@illiakovalenko illiakovalenko merged commit f5e7731 into dev Aug 14, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/jss-3901 branch August 14, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants