Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-angular] Implement Link-List SXA component #1898

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Aug 21, 2024

Description / Motivation

  • Adds LinkList
  • Adjusts base types to be compatible with LayoutService props for LinkList

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team August 21, 2024 19:20
@art-alexeyenko art-alexeyenko changed the title [sitecore-jss] Introduce extra types from Edge schema into models [sitecore-jss-angular] Implement Link-List SXA component Aug 21, 2024
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍🏼

@addy-pathania addy-pathania merged commit 284ab8f into dev Aug 22, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-3562-linklist-ex branch August 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants