Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XM Cloud Proxy] API /api/editing/render endpoint #1908

Merged
merged 44 commits into from
Aug 28, 2024
Merged

[XM Cloud Proxy] API /api/editing/render endpoint #1908

merged 44 commits into from
Aug 28, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 27, 2024 •
edited
Loading

Description / Motivation

  • Introduced /api/editing/render API endpoint for XM Cloud Proxy app
  • Removed extra "apiKey", "siteName" XM Cloud server bundle exports
  • Fixed the API endpoints response to return HTML instead of JSON

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

illiakovalenko and others added 30 commits August 22, 2024 10:58
@illiakovalenko
Initial changes
acb2953
@yavorsk
Merge branch 'feature/jss-3541' into feature/jss-3528
196919c
@illiakovalenko
Update
8f35003
@illiakovalenko
Added unit tests chunk
6becaae
@illiakovalenko
Update
926670b
@illiakovalenko
Updated unit test
87658dd
@illiakovalenko
Updated CHANGELOG, UPGRADE_GUIDE
6ec93ca
@illiakovalenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/JS…
e93eeda 
…S-3541
@illiakovalenko
Updated lock file
63501a2
@illiakovalenko
Updated unit tests
a4d677f
@illiakovalenko
Fixed lint step
f6dd5c6
@yavorsk
initial commit - wip
de55f36
@yavorsk
Merge branch 'feature/jss-3541' into feature/jss-3528
8fe0556
@yavorsk
fix render config call
692db32
@yavorsk
move MetadataQueryParams model to base; update render middleware
3586769
@yavorsk
unit tests wip
37b3e46
@yavorsk
minor updates
a27e0e8
@illiakovalenko
Merge branch 'dev' of https://github.com/Sitecore/jss into feature/js…
03acf72 
…s-3528
@apathania22
pass layout kind to grapqhl request
802b9bd
@apathania22
update changelog
8ea475b
@apathania22
refactor
c266155
@apathania22
resolve merge conflicts
048da12
@apathania22
remove only
900d960
@illiakovalenko
Refactoring and updates
b2ebb9f
@illiakovalenko
Moved MetadataQueryParams to Editing models
649cf83
@illiakovalenko
Merge branch 'feature/jss-3978-layout-kind' of https://github.com/Sit…
53a4f1b 
…ecore/jss into feature/jss-3528
@illiakovalenko
Updated RenderMetadataQueryParams to include sc_layoutKind property
42ddeef
@illiakovalenko
Reverted back LayoutKind
4f49551
@illiakovalenko
Updated UT
b97b002
@illiakovalenko
Remove apiKey, siteName from server.exports in xmcloud addon
1837d9d
@illiakovalenko illiakovalenko added the do-not-review PR's not ready for review label Aug 27, 2024
@illiakovalenko illiakovalenko removed the do-not-review PR's not ready for review label Aug 27, 2024
@illiakovalenko illiakovalenko requested a review from a team August 27, 2024 18:28
art-alexeyenko
art-alexeyenko requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to be figured out, but solid work so far.

packages/sitecore-jss-proxy/src/middleware/editing/config.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/src/middleware/editing/index.test.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/middleware/editing/index.test.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-proxy/src/middleware/editing/render.ts Show resolved Hide resolved
packages/sitecore-jss-proxy/src/middleware/editing/render.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 60f3ec1 into dev Aug 28, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the feature/jss-3528 branch August 28, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk left review comments

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@illiakovalenko @yavorsk @art-alexeyenko @apathania22 @addy-pathania