Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Remove variantId from query in Comp Library #2005

Merged
merged 3 commits into from
Dec 23, 2024
Merged

[sitecore-jss-nextjs] Remove variantId from query in Comp Library #2005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd2125e
[sitecore-jss-nextjs] Remove variantId from query consideration in Co…
art-alexeyenko Dec 18, 2024
614a43e
changelog
art-alexeyenko Dec 18, 2024
a8c763f
remove variant param from component layout svc
art-alexeyenko Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Our versioning strategy is as follows:

### 🎉 New Features & Improvements

* `[nextjs][sitecore-jss-nextjs]` Support for Component Library feature in XMCloud ([#1987](https://github.com/Sitecore/jss/pull/1987)[#2000](https://github.com/Sitecore/jss/pull/2000)[#2002](https://github.com/Sitecore/jss/pull/2002))
* `[nextjs][sitecore-jss-nextjs]` Support for Component Library feature in XMCloud ([#1987](https://github.com/Sitecore/jss/pull/1987)[#2000](https://github.com/Sitecore/jss/pull/2000)[#2002](https://github.com/Sitecore/jss/pull/2002)[#2005](https://github.com/Sitecore/jss/pull/2005))

### 🐛 Bug Fixes

Expand Down
1 change: 0 additions & 1 deletion packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ describe('EditingRenderMiddleware', () => {
pageState: 'normal',
mode: 'library',
dataSourceId: query.sc_datasourceId,
variant: query.sc_variant,
version: query.sc_version,
});

Expand Down
1 change: 0 additions & 1 deletion packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ export class MetadataHandler {
pageState: LayoutServicePageState.Normal,
mode: 'library',
dataSourceId: query.sc_datasourceId,
variant: query.sc_variant || DEFAULT_VARIANT,
version: query.sc_version,
} as ComponentLibraryRenderPreviewData,
{
Expand Down
2 changes: 0 additions & 2 deletions packages/sitecore-jss/src/editing/rest-component-layout-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,6 @@ describe('RestComponentLayoutService', () => {
sc_site: testParams.siteName,
sc_lang: testParams.language,
sc_mode: testParams.editMode,
sc_variant: testParams.variant,
};

// eslint-disable-next-line dot-notation
Expand Down Expand Up @@ -498,7 +497,6 @@ describe('RestComponentLayoutService', () => {
renderingItemId: testParams.renderingId,
sc_lang: testParams.language,
sc_mode: testParams.editMode,
sc_variant: testParams.variant,
};

// eslint-disable-next-line dot-notation
Expand Down
5 changes: 0 additions & 5 deletions packages/sitecore-jss/src/editing/rest-component-layout-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ export interface ComponentLayoutRequestParams {
* site name to be used as context for rendering the component
*/
siteName?: string;
/**
* variant to be rendered for component if set (works with rendering existing component)
*/
variant?: string;
}

/**
Expand Down Expand Up @@ -96,7 +92,6 @@ export class RestComponentLayoutService extends RestLayoutService {
sc_site: params.siteName,
sc_lang: params.language || 'en',
sc_mode: params.editMode,
sc_variant: params.variant,
})
);
}
Expand Down