Responsive image srcset fallback with src output #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
srcSet
to <Image> Component removes thesrc
Attribute.This PR will always output the
src
Attribute, even when asrcSet
Object is passed.This will improve the support for older Browsers, since they might don't support
srcSet
(like IE11). Using the Progressive Enhancement Approach newer Browsers can benefit from thesrcSet
and will ignore thesrc
Attribute.Motivation
Improve Support for older Browsers without the need for a
srcSet
Polyfill - which is difficult to implement when using Jss or Router Links.How Has This Been Tested?
Tests for Image updated to test for
srcSet
/sizes
Attributes output.I used the same values as in the Styleguide Image Example.
Running
npm run test
insideroot
or/packages/sitecore-jss-react
will run the new testTypes of changes
Checklist: