Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-proxy] [#CS0195052] changes to HEAD request handling #487

Merged
merged 4 commits into from
Nov 5, 2020
Merged

[sitecore-jss-proxy] [#CS0195052] changes to HEAD request handling #487

merged 4 commits into from
Nov 5, 2020

Conversation

sc-illiakovalenko
Copy link
Contributor

  • ensure proper connection close and behavior
  • rewrite HEAD to a Layout Service GET
  • don't return body content for a HEAD request

Description

Motivation

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

nickwesselman and others added 4 commits September 17, 2020 00:04
@nickwesselman
[#CS0195052] changes to HEAD request handling
1085cee 
* ensure proper connection close and behavior
* rewrite HEAD to a Layout Service GET
* don't return body content for a HEAD request
@nickwesselman
PR feedback
8a1e6a7 
* only log HEAD rewrites if config.debug == true
@nickwesselman
[#CS0195052] improvements to HEAD handling
a81ecff 
* don't rewrite method for excluded paths
* fixed DEBUG logging for ignored paths
@illiakovalenko
Merge branch 'issue/CS0195052/proxy-head-request-handling' of https:/…
352d8b9 
…/github.com/Sitecore/jss into issue/proxy-head-request-handling
@sc-illiakovalenko sc-illiakovalenko merged commit d68490b into master Nov 5, 2020
@sc-illiakovalenko sc-illiakovalenko deleted the issue/proxy-head-request-handling branch November 5, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc-illiakovalenko @nickwesselman @illiakovalenko