-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NextJS] GraphQL Request Client + GraphQL Sitemap Service #530
Conversation
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
Guessing it's a separate backlog item but will there be an ability to swap out the sitemap service for Disconnected mode, e.g. to use the manifest to get route paths? |
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
I'm not sure how it will be implemented for disconnected mode, but may be we can define separate method for disconnected mode, or create a separate service (may be it's better), it can be replaced in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with some suggested doc/comment changes
Description
Generates a sitemap using Graphql queries
Motivation
How Has This Been Tested?
Types of changes
/docs
directory)Checklist: