Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NextJS] GraphQL Request Client + GraphQL Sitemap Service #530

Merged
merged 15 commits into from
Jan 21, 2021

Conversation

sc-illiakovalenko
Copy link
Contributor

Description

Generates a sitemap using Graphql queries

Motivation

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

@sc-illiakovalenko sc-illiakovalenko changed the title [NextJS] GraphQL Request Client [NextJS] GraphQL Request Client + GraphQL Sitemap Service Jan 15, 2021
@nickwesselman
Copy link
Contributor

Guessing it's a separate backlog item but will there be an ability to swap out the sitemap service for Disconnected mode, e.g. to use the manifest to get route paths?

@sc-illiakovalenko
Copy link
Contributor Author

sc-illiakovalenko commented Jan 20, 2021

Guessing it's a separate backlog item but will there be an ability to swap out the sitemap service for Disconnected mode, e.g. to use the manifest to get route paths?

I'm not sure how it will be implemented for disconnected mode, but may be we can define separate method for disconnected mode, or create a separate service (may be it's better), it can be replaced in getStaticPaths

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with some suggested doc/comment changes

samples/nextjs/src/pages/[[...path]].tsx Outdated Show resolved Hide resolved
samples/nextjs/src/pages/[[...path]].tsx Outdated Show resolved Hide resolved
@sc-illiakovalenko sc-illiakovalenko merged commit 7f179c7 into dev Jan 21, 2021
@sc-illiakovalenko sc-illiakovalenko deleted the feature/439744 branch January 21, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants