Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation to #538 - after rebasing the branch onto dev, it would not let me reopen the original PR
Fix prop-types for errorComponent (this is a Placeholder prop in the react package)
Motivation
This fixes a bug where passing a custom error component via the errorComponent prop (as described in the docs) caused an "Invalid prop" error.
How Has This Been Tested?
Unit tests added.
Manual tests on react sample app.
Create a new CustomError component
Update Layout.js to pass a react component to the errorComponent prop to Placeholder
Verify that Home page renders without errors in disconnected and in EE
Update ContentBlock component to throw an error
Verify that CustomError is rendered on Home page instead of ContentBlock
Update Layout.js to pass a renderProp function to the errorComponent prop to Placeholder <Placeholder errorComponent={() =>
Verify that "Error" is rendered on Home page instead of ContentBlock
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update (non-breaking change; modified files are limited to the /docs directory)
Checklist:
[ x] I have read the Contributing guide.
[ x] My code follows the code style of this project.
[ x] My code/comments/docs fully adhere to the Code of Conduct.
My change is a code change and it requires an update to the documentation.
My change is a documentation change and it requires an update to the navigation.