Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/458679 #575

Merged
merged 6 commits into from
Feb 17, 2021
Merged

Fix/458679 #575

merged 6 commits into from
Feb 17, 2021

Conversation

anastasiya29
Copy link
Contributor

This is a continuation to #538 - after rebasing the branch onto dev, it would not let me reopen the original PR

Fix prop-types for errorComponent (this is a Placeholder prop in the react package)

Motivation
This fixes a bug where passing a custom error component via the errorComponent prop (as described in the docs) caused an "Invalid prop" error.

How Has This Been Tested?
Unit tests added.
Manual tests on react sample app.

Create a new CustomError component
Update Layout.js to pass a react component to the errorComponent prop to Placeholder
Verify that Home page renders without errors in disconnected and in EE
Update ContentBlock component to throw an error
Verify that CustomError is rendered on Home page instead of ContentBlock
Update Layout.js to pass a renderProp function to the errorComponent prop to Placeholder <Placeholder errorComponent={() =>

Error
} />
Verify that "Error" is rendered on Home page instead of ContentBlock
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update (non-breaking change; modified files are limited to the /docs directory)
Checklist:
[ x] I have read the Contributing guide.
[ x] My code follows the code style of this project.
[ x] My code/comments/docs fully adhere to the Code of Conduct.
My change is a code change and it requires an update to the documentation.
My change is a documentation change and it requires an update to the navigation.

@anastasiya29 anastasiya29 merged commit a346dcc into dev Feb 17, 2021
@anastasiya29 anastasiya29 deleted the fix/458679 branch February 17, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants