Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Focused Improvements] Use the app name as the prefix value for placeholders #830

Merged
merged 10 commits into from
Oct 13, 2021
Merged

[Focused Improvements] Use the app name as the prefix value for placeholders #830

merged 10 commits into from
Oct 13, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 12, 2021 •
edited
Loading

Description / Motivation

  • From the authoring UI when author goes to insert placeholder - "Insert component" dialog should show the components for the current site only.
  • Placeholders should contain prefix value, like: react-jss-main

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

@vercel
Copy link

vercel bot commented Oct 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/4YxiGEe7RQBE5AX9c19S7hfdR58C
✅ Preview: https://edge-e2e-styleguide-git-feature-495924-sitecore-jss.vercel.app

@illiakovalenko illiakovalenko requested a review from a team October 12, 2021 15:43
ambrauer
ambrauer approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion / thought, otherwise looks good!

packages/sitecore-jss-cli/src/create/index.ts Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit aa1d3be into dev Oct 13, 2021
@illiakovalenko illiakovalenko deleted the feature/495924 branch October 13, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer