Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] [Authoring] 'Add here' modal does not show allowed items on placeholder #859

Merged
merged 1 commit into from
Nov 23, 2021
Merged

[Vue] [Authoring] 'Add here' modal does not show allowed items on placeholder #859

merged 1 commit into from
Nov 23, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 22, 2021 •
edited
Loading

Description / Motivation

  • It's impossible to set key using Vue 3 attributes, we can manipulate it after DOM render is finished.
  • Fixed apollo-client version, new version has breaking changes for us

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team November 22, 2021 17:08
@vercel
Copy link

vercel bot commented Nov 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/2oEgpoPkCi9RgZa8UcXMCVATe2g7
✅ Preview: https://edge-e2e-styleguide-git-bugfix-505752-sitecore-jss.vercel.app

CobyPear
CobyPear approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@CobyPear CobyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@illiakovalenko illiakovalenko merged commit f7db1dc into dev Nov 23, 2021
@illiakovalenko illiakovalenko deleted the bugfix/505752 branch November 23, 2021 08:40
@CobyPear CobyPear mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CobyPear CobyPear CobyPear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @CobyPear