Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializer for angular sample #880

Merged
merged 118 commits into from
Dec 16, 2021
Merged

Initializer for angular sample #880

merged 118 commits into from
Dec 16, 2021

Conversation

CobyPear
Copy link
Contributor

@CobyPear CobyPear commented Dec 9, 2021 •
edited
Loading

PLEASE DO NOT MERGE!!

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

CobyPear and others added 30 commits November 15, 2021 15:19
WIP: nextjs generator
08a1235
WIP: diy generator
0c22440
WIP: nextjs generator - build templates
1b063a6
@ambrauer
Start of dedicated package 'create-sitecore-jss'
af1526c
@ambrauer
remove package-lock
95a9b8c
@ambrauer
Stubbed out build-templates.ts, added .gitignore
06143ae
@addy-pathania
added build templates
9db0d7e
WIP: nextjs initializer- ejs file render
d333ed8
@ambrauer
Handling template command line parameter / prompt
f606310
@ambrauer
Allow token replacement on file names
e046d58
@ambrauer
remove remaining disconnected files
d13a632
@ambrauer
Added check for empty directory
58a4e6e
@ambrauer
Remove remaining styleguide code
d370675
@ambrauer
test name change for lerna versioning
175bed0
@ambrauer
updated yarn.lock
0847304
@ambrauer
lerna test
451c35d
@ambrauer
Revert "lerna test"
1036285 
This reverts commit 451c35d.
@ambrauer
get rid of mkdirp helper in favor of fs-extra
3d18acf
Add support for 'add' positinal param
4765263
@ambrauer
Initial watch script
010a3b3
Fix templates, add prefix flag
6ffd8cd
@addy-pathania
added logs, detect initializer, feed args from json
ac78d03
@addy-pathania
refined the config file and added switch case to initializers
c044535
@addy-pathania
merged with diy-generator-watch
53b1dc1
Adding diffing to 'add'
9320377
Fix merge conflict
066b79f
Styleguide sub-initializer WIP: prompts for diffs working
ce6228d
Update yes flag to override with passed in args
d62357a
WIP: Add dependencies/scripts to package.json during post-init
2a3eeef
@ambrauer
Basic "next steps" introduced, some linting errors fixed
f592b84
illiakovalenko
illiakovalenko requested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have many places where you didn't use getAppPrefix helper, but it should be used. Check each file and use it

packages/create-sitecore-jss/src/templates/angular/data/routes/en.yml Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/data/routes/en.yml Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/data/routes/graphql/en.yml Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/data/routes/graphql/en.yml Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/data/routes/graphql/sample-1/en.yml Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/data/routes/graphql/sample-2/en.yml Outdated Show resolved Hide resolved
...es/create-sitecore-jss/src/templates/angular/data/routes/styleguide/custom-route-type/en.yml Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/package.json Outdated Show resolved Hide resolved
@CobyPear
Update settings.json
d451695 
why does this keep coming back? 😅
illiakovalenko
illiakovalenko requested changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! See few comments, looks good

packages/create-sitecore-jss/watch.json Outdated Show resolved Hide resolved
packages/sitecore-jss-cli/.vscode/launch.json Outdated Show resolved Hide resolved
illiakovalenko
illiakovalenko approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CobyPear CobyPear merged commit 7a50b44 into dev Dec 16, 2021
@CobyPear CobyPear deleted the diy-generator-angular branch December 16, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CobyPear @illiakovalenko @ambrauer @addy-pathania