Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue][Horizon] Cannot add a new rendering or highlight existing #895

Merged
merged 4 commits into from
Dec 21, 2021
Merged

[Vue][Horizon] Cannot add a new rendering or highlight existing #895

merged 4 commits into from
Dec 21, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Dec 20, 2021 •
edited
Loading

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Dec 20, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/8aj8s4YAYGBkStY5uHJmNgANQbBg
✅ Preview: Failed

[Deployment for 9a060b7 failed]

@illiakovalenko illiakovalenko changed the title [Vue][Horizon] Cannot add a new rendering [Vue][Horizon] Cannot add a new rendering or highlight existing Dec 20, 2021
@illiakovalenko illiakovalenko requested a review from a team December 20, 2021 12:49
ambrauer
ambrauer approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though looks like there are some failing tests.

@illiakovalenko illiakovalenko merged commit 1b5cf99 into dev Dec 21, 2021
@illiakovalenko illiakovalenko deleted the bugfix/511325 branch December 21, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer