Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAV] Change the classname of ContentBlock from display-4 to contentTitle #908

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[RAV] Change the classname of ContentBlock from display-4 to contentTitle #908

merged 1 commit into from
Jan 13, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 13, 2022 •
edited
Loading

Description / Motivation

  • NextJS tests are failing because we are validating the ContentBlock content by checking the classname
  • We should have same the classname for each framework

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Jan 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/7Ax1Fvf5mkAXdpbyUx71H6opHCLT
✅ Preview: Failed

@illiakovalenko illiakovalenko requested a review from a team January 13, 2022 13:46
@ambrauer ambrauer merged commit 38e5b8f into dev Jan 13, 2022
@ambrauer ambrauer deleted the feature/515294 branch January 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer