Throw error when run jss start using FETCH_WITH=GraphQL #920
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/5k6ruPPVm5trTfPLdwsS2RTSVogZ [Deployment for be8d3d8 failed] |
packages/create-sitecore-jss/src/templates/angular/scripts/bootstrap.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/scripts/bootstrap.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/react/scripts/bootstrap.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/scripts/bootstrap.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/package.json
Outdated
Show resolved
Hide resolved
…pt in package.json
| @@ -23,6 +23,7 @@ | |||
| "allowSyntheticDefaultImports": true, | |||
| "esModuleInterop": true, | |||
| "resolveJsonModule": true, | |||
| "useUnknownInCatchVariables": false, | |||
There was a problem hiding this comment.
Just curious - what was the reason for adding this?
There was a problem hiding this comment.
Build for the nextjs package was failing in the editing-render-middleware.ts file.
I got this error in the catch block.
Starting typescript v4.0, catch clause variables have type unknown instead of any.
This is a workaround I found.
There was a problem hiding this comment.
Hmm. This change actually seems to be breaking the build on CI.
tsconfig.json(26,5): error TS5023: Unknown compiler option 'useUnknownInCatchVariables'.
We should probably revert this. Guessing it's something on your local env that's causing the error for you?
There was a problem hiding this comment.
Yeah, probably something with my local environment.
The user should see a friendly error message when they try to run jss start i.e disconnected mode when fetchWtih is set to 'GraphQL'.
Description / Motivation
Testing Details
Types of changes