Introduce new CSS length with CSS calculations included #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!pr extract |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jym77
changed the title
|
!pr extract |
Jym77
changed the title
Jym77
changed the title
rcj-siteimprove
previously requested changes
May 22, 2023
Co-authored-by: Rolf Christian Jørgensen <[email protected]>
rcj-siteimprove
previously approved these changes
May 22, 2023
rcj-siteimprove
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1202
Prepare the architecture for supporting CSS calculations in all numeric types, including inside "composed" type such as RGB colors.
This set up calculated lengths as a value type in
alfa-css, and use them in one property inalfa-style.Ultimately, the goal is to use that in all places, and stop exporting
calculation/numeric/length, then do the same for other numeric type (plus the mixeddimension-percentageones. This PR only showcases the solution and is big enough already…