Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compound Length from alfa-style #1424

Merged
merged 8 commits into from
May 25, 2023
Merged

Remove compound Length from alfa-style #1424

merged 8 commits into from
May 25, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented May 23, 2023

Part of #1202

@Jym77 Jym77 self-assigned this May 23, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label May 23, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented May 23, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review May 23, 2023 13:00
@Jym77 Jym77 requested review from a team and rcj-siteimprove May 23, 2023 13:00
github-advanced-security[bot]
github-advanced-security bot found potential problems May 23, 2023
View reviewed changes
packages/alfa-style/src/element/predicate/has-outline.ts Fixed Show resolved Hide resolved
packages/alfa-rules/src/sia-r62/serialise.ts
: initial.toString();
// TODO: end workaround, inline variables and remove redudant test.

return property !== undefined && value === str ? "" : value;

Check warning

Code scanning / CodeQL

Comparison between inconvertible types

Variable 'property' cannot be of type undefined, but it is compared to ['undefined'](1) of type undefined.
rcj-siteimprove
rcj-siteimprove previously approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just found some potential polishing

packages/alfa-css/src/value/numeric/length.ts Show resolved Hide resolved
packages/alfa-css/src/value/numeric/length.ts Show resolved Hide resolved
packages/alfa-style/src/element/predicate/has-outline.ts Fixed Show resolved Hide resolved
@Jym77 Jym77 requested a review from rcj-siteimprove May 25, 2023 09:19
@Jym77 Jym77 enabled auto-merge May 25, 2023 09:19
@Jym77 Jym77 added this pull request to the merge queue May 25, 2023
Merged via the queue into main with commit 792dd45 May 25, 2023
@Jym77 Jym77 deleted the remove-hybrid-length-from-style branch May 25, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove