Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace .elementDescendants() with .getElementDescendants() #1425

Merged
merged 4 commits into from
May 26, 2023
Merged

Replace .elementDescendants() with .getElementDescendants() #1425

merged 4 commits into from
May 26, 2023

Conversation

rcj-siteimprove
Copy link
Contributor

Follows up on #1413, part of #1037.

@rcj-siteimprove rcj-siteimprove requested review from a team and Jym77 May 25, 2023 14:59
@rcj-siteimprove rcj-siteimprove self-assigned this May 25, 2023
@rcj-siteimprove rcj-siteimprove added the internal Change that only affects internal APIs or other non-public aspects label May 25, 2023
@Jym77
Copy link
Contributor

Jym77 commented May 26, 2023

!pr extract

Jym77
Jym77 requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an (unrelated) possible optimisation with using getIdMap. I guess we should as well do it now.

packages/alfa-rules/src/sia-r81/rule.ts Outdated Show resolved Hide resolved
@rcj-siteimprove rcj-siteimprove added major Backwards-incompatible change that touches public API and removed internal Change that only affects internal APIs or other non-public aspects labels May 26, 2023
@rcj-siteimprove rcj-siteimprove requested a review from Jym77 May 26, 2023 10:04
@rcj-siteimprove rcj-siteimprove added this pull request to the merge queue May 26, 2023
Merged via the queue into main with commit ffac264 May 26, 2023
@rcj-siteimprove rcj-siteimprove deleted the element-descendant-cleanup branch May 26, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

Assignees

@rcj-siteimprove rcj-siteimprove

Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcj-siteimprove @Jym77