Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper type for CSS parser #1447

Merged
merged 11 commits into from
Jul 11, 2023
Merged

Helper type for CSS parser #1447

merged 11 commits into from
Jul 11, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 4, 2023

Part of #1202

@Jym77 Jym77 self-assigned this Jul 4, 2023
@Jym77 Jym77 added the internal Change that only affects internal APIs or other non-public aspects label Jul 4, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 4, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review July 4, 2023 12:58
@Jym77 Jym77 requested review from a team and rcj-siteimprove July 4, 2023 12:58
@Jym77 Jym77 enabled auto-merge July 4, 2023 12:59
@Jym77
Copy link
Contributor Author

Jym77 commented Jul 4, 2023

!pr extract

rcj-siteimprove
rcj-siteimprove reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the refactor has made some import statements redundant

packages/alfa-css/src/calculation/numeric/angle.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/calculation/numeric/integer.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/calculation/numeric/length.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/calculation/numeric/number.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/calculation/numeric/percentage.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/value/transform/translate.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/value/keyword.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/value/position.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/value/shadow.ts Outdated Show resolved Hide resolved
packages/alfa-css/src/value/string.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 requested a review from rcj-siteimprove July 11, 2023 10:58
@Jym77 Jym77 added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit 9abb81f Jul 11, 2023
@Jym77 Jym77 deleted the css-parser branch July 11, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
internal Change that only affects internal APIs or other non-public aspects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove